12 comments

  • pjc50 2 hours ago
    I like how C# handles this. You're not forced to support cancellation, but it's strongly encouraged. The APIs all take a CancellationToken, which is driven by a CancellationTokenSource from the ultimate caller. This can then either be manually checked, or when you call a library API it will notice and throw an OperationCancelledException.

    Edit: note that there is a "wrong" way to do this as well. The Java thread library provides a stop() function. But since that's exogenous, it doesn't necessarily get cleaned up properly. We had to have an effort to purge it from our codebase after discovering that stopping a thread while GRPC was in progress broke all future GRPC calls from all threads, presumably due to some shared data structure being left inconsistent. "Cooperative" (as opposed to preemptive) cancel is much cleaner.

    • torginus 5 minutes ago
      I don't like it - you're forced to pass around this token, constantly manage the lifecycle of cancellation sources - and incredibly bug prone thing in async context, and it quickly gets very confusing when you have multiple tokens/sources.

      I understand why they did it - a promise essentially is just some code, and a callback that will be triggered by someone at some point in time - you obviously get no quality of service promises on what happens if you cancel a promise, unless you as a dev take care to offer some.

      It's also obvious that some operations are not necessarily designed to be cancellable - imagine a 'delete user' request - you cancelled it, now do you still have a user? Maybe, maybe you have some cruft lying around.

      But still, other than the obvious wrong solution - C# had a Thread.Abort() similar to the stop() function that you mentioned, that was basically excommunicated from .NET more then a decade ago, I'm still not happy with the right one.

    • teraflop 2 hours ago
      I am surprised that you had to go out of your way to remove Thread.stop from existing Java code. It's been deprecated since 1998, and the javadoc page explains pretty clearly why it's inherently unsafe.

      It's hard to miss all the warnings unless you're literally just looking at the method name and nothing else.

      • wiseowise 34 minutes ago
        That’s barely-junior interview question indeed.
      • pjc50 2 hours ago
        I was certainly surprised to see it when I found it.
    • esprehn 2 hours ago
      AbortSignal is same thing on the Web. It's unfortunate TC39 failed to ever bring a CancelToken to the language to standardize the pattern outside browsers.
      • runarberg 2 hours ago
        TC39 seems to be failing at many things for the past 10 years.
    • wiseowise 35 minutes ago
      > "Cooperative" (as opposed to preemptive) cancel is much cleaner.

      Which what Thread.interrupt does.

    • CharlieDigital 2 hours ago
      C# has very good support for this.

      You can even link cancellation tokens together and have different cancellation "roots".

  • eithed 2 hours ago
    > Promise itself has no first-class protocol for cancellation, but you may be able to directly cancel the underlying asynchronous operation, typically using AbortController.

    https://developer.mozilla.org/en-US/docs/Web/JavaScript/Refe...

  • mohsen1 2 hours ago
    Back in 2012 I was working on a Windows 8 app. Promises were really only useful on the Windows ecosystem since browser support was close to non existent. I googled "how to cancel a promise" and the first results were Christian blogs about how you can't cancel a promise to god etc. Things haven't changes so much since, still impossible to cancel a promise (I know AbortSignal exists!)
  • thomasnowhere 1 hour ago
    The never-resolving promise trick is clever but what caught me off guard is how clean the GC behavior is. Always assumed hanging promises would leak in long-lived apps but apparently not as long as you drop the references.
  • bastawhiz 58 minutes ago
    Be careful with this, though. If a promise is expected to resolve and it never does, and the promise needs to resolve or reject to clean up a global reference (like an event listener or interval), you'll create a memory leak. It's easy to end up with a leak that's almost impossible to track down, because there isn't something obvious you can grep for.
    • hungryhobbit 54 minutes ago
      This is addressed at the end of the article:

        The catch
      
        You're relying on garbage collection, which is nondeterministic. You don't get to know when the suspended function is collected. For our use case, that's fine. We only need to know that it will be collected, and modern engines are reliable about that.
      
        The real footgun is reference chains. If anything holds a reference to the hanging promise or the suspended function's closure, the garbage collector can't touch it. The pattern only works when you intentionally sever all references.
  • cush 2 hours ago
    GC can be very slow. Relying on it for control flow is a bold move
    • BlueGreenMagick 1 hour ago
      I don't think the control flow relies on GC.

      The control flow stops because statements after `await new Promise(() => {});` will never run.

      GC is only relied upon to not create a memory leak, but you could argue it's the same for all other objects.

    • dominicrose 1 hour ago
      as long as there's no leak interrupting a promise should be good for performance overall, not necessarily for the front-end but for the whole chain.
    • augusto-moura 1 hour ago
      Not that very slow for web applications. Maybe for real time or time-sensitive applications. For most day to day web apps GC pauses are mostly unnoticeable, unless you are doing something very wrong
  • abraxas 2 hours ago
    and so the thirty year old hackathon continues...
  • dimitropoulos 3 hours ago
    > Libraries like Effect have increased the popularity of generators, but it's still an unusual syntax for the vast majority of JavaScript developers.

    I'm getting so tired of hearing this. I loved the article and it's interesting stuff, but how many more decades until people accept generators as a primitive??

    used to hear the same thing about trailing commas, destructuring, classes (instead of iife), and so many more. yet. generators still haven't crossed over the magic barrier for some reason.

    • horsawlarway 2 hours ago
      There just aren't that many spots where the average js dev actually needs to touch a generator.

      I don't really see generators ever crossing into mainstream usage in the same way as the other features you've compared them to. Most times... you just don't need them. The other language tools solve the problem in a more widely accessible manner.

      In the (very limited & niche) subset of spots you do actually need a generator, they're nice to have, but it's mostly a "library author" tool, and even in that scope it's usage just isn't warranted all that often.

      • no_wizard 1 hour ago
        mainly because they messed up on implementation, in two ways. This is of course my opinion.

        The first being `.next()` on the returned iterators. If you pass an argument to it, the behavior is funky. The first time it runs, it actually doesn't capture the argument, and then you can capture the argument by assigning `yield` to a variable, and do whatever, but its really clunky from an ergonomic perspective. Which means using it to control side effects is clunky.

        The second one how it is not a first class alternative to Promise. Async Generators are not the most ergonomic thing in the world to deal with, as you have the issues above plus you have to await everything. Which I understand why, but because generators can't be used in stead of Promises, you get these clunky use cases for using them.

        They're really only useful as a result, for creating custom iterator patterns or for a form of 'infinite stream' returns. Beyond that, they're just not all that great, and it often takes combining a couple generators to really get anything useful out of them.

        Thats been my experience, and I've tried to adopt generators extensively a few times in some libraries, where I felt the pattern would have been a good fit but it simply didn't turn out most of the time.

      • gbuk2013 1 hour ago
        It is a specialised instrument but a useful one: batch processing and query pagination are first class use cases for generators that can really simplify business logic code. Stream processing is another and in fact Node.js streams have had a generator API for several releases now.
    • yeittrue 3 hours ago
      Generators peaked in redux- saga and thunk days before we had widespread support for async/await.

      You're right, mostly pointless syntax (along with Promise) now that we can await an async function anyway, especially now with for .. of to work with Array methods like .map

      But there are still some use cases for it, like with Promise. Like for example, making custom iterators/procedures or a custom delay function (sync) where you want to block execution.

  • game_the0ry 3 hours ago
    Off topic, but that site has really nice design
    • williamdclt 2 hours ago
      Mh, I couldn't read due to the huge contrast and had to switch to reader mode, so...
      • jazzypants 2 hours ago
        I personally find it to be perfectly readable. I've heard of people with issues with white text on a black background, but I don't fully understand it. Do you have astigmatism?
      • seattle_spring 1 hour ago
        What colors were you seeing? It's light white text on a black background for me-- both super common and plenty readable.
      • game_the0ry 2 hours ago
        I mean, I'm not a designer but it was interesting enough to call out.
  • afarah1 2 hours ago
    You can also race it with another promise, which e.g. resolves on timeout.
    • Keyframe 54 minutes ago
      You can but it still won't get cancelled. I found out when I tried to implement a hard time limit to a call.
  • TZubiri 1 hour ago
    [flagged]
    • seattle_spring 1 hour ago
      > If I know the javascript ecosystem, and I think I do

      You think you do, but...